[Buildroot] [PATCH v3 1/1] reaver: fix build errors with static lib
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Wed Apr 25 20:32:36 UTC 2018
Hello,
On Sun, 22 Apr 2018 17:51:59 +0200, Guillaume W. Bres wrote:
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix at gmail.com>
This commit log was way too short, and lacked a reference to the
autobuilder failure being fixed. I've fixed that when applying.
> +ifeq ($(BR2_STATIC_LIBS),y)
> +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
> +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
Other issues/improvements here:
- We generally pass such variables in <pkg>_CONF_ENV
- A single <pkg>_CONF_ENV assignment is enough
- LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still
needs to be passed.
I've fixed those different problems, and applied. See the final commit
at:
https://git.buildroot.org/buildroot/commit/?id=559416ffe2039d1cac94e348bd28e963adf008a4
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list