[Buildroot] [PATCH 2/2] core/pkg-infra: don't enforce site-method for extra downloads

Luca Ceresoli luca at lucaceresoli.net
Wed Apr 25 20:43:19 UTC 2018


Hi Yann,

On 25/04/2018 21:41, Yann E. MORIN wrote:
> The site method only ever applies to the main download, while extra
> downloads are always to be fetches with wget.
> 
> However, the site method is prepended to the URL from within the
> DOWNLOAD macro (well, a variable evaluated in the DOWNLOAD macro),
> which is called for each download of a package, thus effectively
> prepending the site method to all downloads, even the extra ones (and
> the patches).
> 
> We fix that by prepending the site method from within the
> generic-package infra, so that it only applies to the main download.
> 
> For that, we move the main _SOURCE out of the foreach loop, so that
> we can prepend the site-method to it, without impacting the other
> downloads.
> 
> Reported-by: Luca Ceresoli <luca at lucaceresoli.net>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Luca Ceresoli <luca at lucaceresoli.net>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>

Thanks for such a prompt fix!

Reviewed-by: Luca Ceresoli <luca at lucaceresoli.net>
Tested-by: Luca Ceresoli <luca at lucaceresoli.net>

-- 
Luca



More information about the buildroot mailing list