[Buildroot] [git commit branch/next] fs/btrfs: remove destination file before generation

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Aug 25 21:59:23 UTC 2018


commit: https://git.buildroot.net/buildroot/commit/?id=f023810f04ea0cf4633465e838cb2f7eae2b1727
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/next

btrfs will happily use an existing destination file if it
already exists, increasing its size if needed. Hoever, it
will never decrease the size, even if the requested size
is smaller than the existing file.

So, remove any previously existing destination file before
generating the new filesystem.

Note: the original submission by Robert did that, but as
this case was not obvious, the removal was dropped by a
refactoring when the patch was initially applied.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Cc: Robert J. Heywood <robert.heywood at codethink.co.uk>
Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
[Thomas: use $@ instead of $(@), use $(RM) instead of rm.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
---
 fs/btrfs/btrfs.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/btrfs.mk b/fs/btrfs/btrfs.mk
index ad00153c26..388516389b 100644
--- a/fs/btrfs/btrfs.mk
+++ b/fs/btrfs/btrfs.mk
@@ -29,6 +29,7 @@ BTRFS_OPTS = \
 ROOTFS_BTRFS_DEPENDENCIES = host-btrfs-progs
 
 define ROOTFS_BTRFS_CMD
+	$(RM) -f $@
 	$(HOST_DIR)/bin/mkfs.btrfs $(BTRFS_OPTS) $@
 endef
 


More information about the buildroot mailing list