[Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+

Baruch Siach baruch at tkos.co.il
Fri Aug 10 05:43:25 UTC 2018


Hi Peter,

Baruch Siach writes:
> On Wed, Aug 08, 2018 at 04:55:06PM +0200, Peter Korsgaard wrote:
>> >>>>> "Baruch" == Baruch Siach <baruch at tkos.co.il> writes:
>>  >> >  config BR2_PACKAGE_UBOOT_TOOLS
>>  >> >  	bool "u-boot tools"
>>  >> > +	depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
>>  >>
>>  >> What about host-uboot-tools?
>>
>>  > The only config symbols that builds host-uboot-tools is
>>  > BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on
>>  > BR2_HOST_GCC_AT_LEAST_4_7, right?
>>
>>  > AFAIU, there is no way to directly make host packages depend on Kconfig
>>  > symbols.
>>
>> Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and
>> a number of places where it is selected?
>
> I see. I'll run another build just to verify that -std=gnu11 is used in
> host-uboot-tools, and send another patch.

It turns out that host-uboot-tools is not affected. That's because we
force host CFLAGS in HOST_UBOOT_TOOLS_MAKE_OPTS. I posted a patch that
does the same for uboot-tools, and marked this patch as Rejected.

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -



More information about the buildroot mailing list