[Buildroot] [PATCH] openresolv: new package

Matthew Weber matthew.weber at rockwellcollins.com
Tue Aug 14 14:37:05 UTC 2018


Thomas,
On Tue, Aug 14, 2018 at 9:12 AM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello Matt,
>
> On Tue,  7 Aug 2018 08:29:46 -0500, Matt Weber wrote:
>
> >  package/Config.in                  |  1 +
> >  package/openresolv/Config.in       | 13 +++++++++++++
> >  package/openresolv/openresolv.hash |  3 +++
> >  package/openresolv/openresolv.mk   | 12 ++++++++++++
> >  4 files changed, 29 insertions(+)
>
> Entry in DEVELOPERS file is missing.

Ah yes, will add.

>
> > diff --git a/package/Config.in b/package/Config.in
> > index f5a1749..2ad6687 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1843,6 +1843,7 @@ endif
> >       source "package/open-plc-utils/Config.in"
> >       source "package/openntpd/Config.in"
> >       source "package/openobex/Config.in"
> > +     source "package/openresolv/Config.in"
> >       source "package/openssh/Config.in"
> >       source "package/openswan/Config.in"
> >       source "package/openvpn/Config.in"
> > diff --git a/package/openresolv/Config.in b/package/openresolv/Config.in
> > new file mode 100644
> > index 0000000..3eb736f
> > --- /dev/null
> > +++ b/package/openresolv/Config.in
> > @@ -0,0 +1,13 @@
> > +comment "openresolv needs a bash shell"
> > +     depends on !BR2_SYSTEM_BIN_SH_BASH
>
> Are you sure it needs a bash shell ? Indeed in
> https://github.com/rsmarples/openresolv, the #1 argument for resolvconf
> compared to its Debian variant is:
>
> ""
> Works with POSIX shell and userland
> ""

This dialog should have been included in the description related to
use of getopts vs getopt in the script.

https://github.com/rsmarples/openresolv/commit/a694a49c41ffdc0e215320459af009d44482b065#commitcomment-29850615

>
> > $(eval $(autotools-package))
>
> This package is not using the autotools. The configure script is not
> generated by autoconf, the Makefile is not generated by automake. So,
> generic-package should be used, and not autotools-package.

Missed this, looks like they are mimic'n a configure script.  It is
working as a autotools pkg, but I'll pull the commands over to a
generic.

Matt



More information about the buildroot mailing list