[Buildroot] [PATCH 8/8] package/mender: set version in go linker

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Aug 15 12:43:12 UTC 2018


Hello,

On Wed, 15 Aug 2018 14:32:23 +0200, Mirza Krak wrote:

> I would not know the answer to this as my experience is somewhat
> limited when it comes to golang. But if we take a look at
> docker-containerd.mk, it does this:
> 
>     DOCKER_CONTAINERD_LDFLAGS = \
>                   -X
> github.com/docker/containerd.GitCommit=$(DOCKER_CONTAINERD_VERSION)
> 
> Maybe above an argument against putting it in pkg-golank.mk?

Indeed, every package seems to use its own custom property, so your
patch looks good. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list