[Buildroot] [PATCH 1/1] libjwt: new package.

Mikael Eliasson mikael at robomagi.com
Tue Aug 21 18:34:34 UTC 2018


Hi,
2018-08-12 21:25 GMT+02:00 Yann E. MORIN <yann.morin.1998 at free.fr>:

> Mickael, All,
>
> On 2018-08-12 18:08 +0200, Mikael Eliasson spake thusly:
> > Hi Thomas,
> > Not used to using mailing lists so this may not be the correct way to
> send a follow up patch. It is attached.
>
> Just send it again with git send-email.
>
> Also, it is customary to not top-post like you did, but to reply in-line
> (like I'm doing).
>
> > I think I have made all the changes you requested. I had also missed
> including package/Config.in.
> > Tested with test-pkg -a:
> > 47 builds, 0 skipped, 0 build failed, 0 legal-info failed
>
> Great! :-)
>
> Yet, I have a very small comment, see below...
>
> [--SNIP--]
> > diff --git a/package/libjwt/0001-Declare-project-C-only.patch
> b/package/libjwt/0001-Declare-project-C-only.patch
> > new file mode 100644
> > index 0000000000..cfb3cc8425
> > --- /dev/null
> > +++ b/package/libjwt/0001-Declare-project-C-only.patch
> > @@ -0,0 +1,16 @@
> > +Declares project C only.
> > +
> > +Signed-off-by: Mikael Eliasson <mikael at robomagi.com>
> > +diff --git a/CMakeLists.txt b/CMakeLists.txt
> > +index 5cd1910..aefb87d 100644
> > +--- a/CMakeLists.txt
> > ++++ b/CMakeLists.txt
> > +@@ -4,7 +4,7 @@ if (MSVC)
> > +     set (CMAKE_SYSTEM_VERSION 8.1 CACHE TYPE INTERNAL FORCE)
> > + endif ()
> > +
> > +-project (jwt)
> > ++project (jwt C)
>
> It would be great if you were to send this change upstream, so that we
> can drop this patch next time we update the package.
>
> > + list (APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
> > +
> [--SNIP--]
> > diff --git a/package/libjwt/libjwt.mk b/package/libjwt/libjwt.mk
> > new file mode 100644
> > index 0000000000..8863fb436a
> > --- /dev/null
> > +++ b/package/libjwt/libjwt.mk
> > @@ -0,0 +1,21 @@
> > +###########################################################
> #####################
> > +#
> > +# libjwt
> > +#
> > +###########################################################
> #####################
> > +
> > +LIBJWT_VERSION = v1.9.0
> > +LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION))
> > +LIBJWT_INSTALL_STAGING = YES
> > +LIBJWT_DEPENDENCIES = jansson
> > +LIBJWT_LICENSE = LGPL-3.0
> > +LIBJWT_LICENSE_FILES = COPYING.LIB
>
> I know there is no strongly documented ordering, but I like that the
> descriptive metadata goes first, while the building metadata goes last,
> with adequate spacing to separate the types of data, like so:
>
>     LIBJWT_VERSION = v1.9.0
>     LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION))
>     LIBJWT_LICENSE = LGPL-3.0
>     LIBJWT_LICENSE_FILES = COPYING.LIB
>
>     LIBJWT_DEPENDENCIES = jansson
>
>     LIBJWT_INSTALL_STAGING = YES
>
> It kind of follows some "logic": where to get it, what itslicensing is,
> what it needs, what it provides, how we build it.
>
> No need to re-send. If a maintainer agrees, he can re-reorder when
> applying, or he can just apply it as-is if he believes that is OK as-is.
>
Is there anything else you need me to do to include this package? I cannot
see that it has been added in github yet.


>
> Regards,
> Yann E. MORIN.
>
> > +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> > +LIBJWT_DEPENDENCIES += openssl
> > +else
> > +LIBJWT_DEPENDENCIES += gnutls
> > +LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1
> > +endif
> > +
> > +$(eval $(cmake-package))
> > --
> > 2.17.1
> >
>
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
>
> --
> .-----------------.--------------------.------------------.-
> -------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
> '------------------------------^-------^------------------^-
> -------------------'
>



-- 
Mikael Eliasson
Telefon:
+46703900837
Email:
mikael at robomagi.com
Adress:
Robomagi AB
Tångringsgatan 26A 78430 Borlänge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180821/92ed0ce2/attachment-0002.html>


More information about the buildroot mailing list