[Buildroot] [PATCH] libssh: fix cross compile with older cmake

Jan Kundrát jan.kundrat at cesnet.cz
Thu Aug 23 09:24:47 UTC 2018


On středa 22. srpna 2018 23:58:30 CEST, Baruch Siach wrote:
> +# cmake older than 3.10 require this to avoid try_run() in FindThreads
> +LIBSSH_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF

Are you sure that this is a correct fix? From reading the 
FindThreads.cmake, passing OFF looks like it results in not feeding the 
-pthread option to the compiler. That breaks some scenarios such as ASAN, 
see [1] for details.

Cheers,
Jan

[1] https://gitlab.kitware.com/cmake/cmake/issues/16609



More information about the buildroot mailing list