[Buildroot] [PATCH 1/1] git: Fix libintl linking if there is no full gettext support

Vadim Kochan vadim4j at gmail.com
Sat Aug 25 12:25:50 UTC 2018


Hi Thomas,

On Sat, Aug 25, 2018 at 3:12 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello Vadim,
>
> On Sat, 25 Aug 2018 14:24:37 +0300, Vadim Kochan wrote:
>
> > > Could you give some minimal Buildroot configuration that exhibits the
> > > issue ?
> >
> > So I just did:
> > 1) make menuconfig
> > 2) Toolchain -> WCHAR
> > 3) System -> NLS
> > 4) Target packages -> Development -> git
> >
> > I attached also config file w/o '#' and empty lines.
> >
> > P.S.
> > Not sure if the fix is good, will try to cook v2 ...
>
> OK, I can reproduce (we should really add some testing for NLS enabled
> in our autobuilders, let's do this after the 2018.08 release). However,
> the proper fix is:
>
>  ifeq ($(BR2_SYSTEM_ENABLE_NLS),)
>  GIT_MAKE_OPTS += NO_GETTEXT=1
> +else
> +GIT_EXTLIBS += $(TARGET_NLS_LIBS)
>  endif
>
> TARGET_NLS_LIBS is automaticaly set to -lintl when gettext provides the
> full libintl library we need to link against.
>
> Could you test this, and send an updated patch ?
>
> Thanks!

Sure! Thanks for the hint! I was also thinking about to just remove
LIBC_CONTAINS_LIBINTL
line from the config.mak.autogen file via $(SED), so this will
indicate for the git's Makefile
to add -lintl to the linker.

Regards,



More information about the buildroot mailing list