[Buildroot] [PATCH 1/4] netsurf: add optional dependency freetype

François Perrad francois.perrad at gadz.org
Mon Dec 17 04:37:24 UTC 2018


Le dim. 16 déc. 2018 à 21:51, Thomas Petazzoni <thomas.petazzoni at bootlin.com>
a écrit :

> Hello François,
>
> Even though I applied the series, I have a few comments.
>
> On Wed, 12 Dec 2018 08:14:52 +0100, Francois Perrad wrote:
> > Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
> > ---
> >  .../netsurf/0002-fix-freetype-detection.patch | 28 +++++++++++++++++++
> >  package/netsurf/netsurf.mk                    |  7 +++++
> >  2 files changed, 35 insertions(+)
> >  create mode 100644 package/netsurf/0002-fix-freetype-detection.patch
> >
> > diff --git a/package/netsurf/0002-fix-freetype-detection.patch
> b/package/netsurf/0002-fix-freetype-detection.patch
> > new file mode 100644
> > index 000000000..27c0440e1
> > --- /dev/null
> > +++ b/package/netsurf/0002-fix-freetype-detection.patch
> > @@ -0,0 +1,28 @@
> > +From 85336f2404b9583267019650ea0112ebf1bb571a Mon Sep 17 00:00:00 2001
> > +From: Francois Perrad <francois.perrad at gadz.org>
> > +Date: Wed, 28 Nov 2018 17:59:44 +0100
> > +Subject: [PATCH 2/2] fix freetype detection
>
> When generating patches, use the -N option of git format-patch to avoid
> the numbering: it provides patches that use [PATCH] instead of [PATCH
> X/Y]. We prefer just [PATCH] because the X/Y often get invalid. Your
> series is a good example: this patch adds a PATCH 2/2 patch, and the
> next patch adds a 3/3 patch, and then another patch adds a 4/4 patch.
>
> Another comment: did you submit all those patches to the upstream
> netsurf project ?
>

I will do.

note: this package still fail on autobuilders, see fix on
https://patchwork.ozlabs.org/patch/1013055/

François


>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181217/012e8094/attachment-0002.html>


More information about the buildroot mailing list