[Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency

Petr Vorel petr.vorel at gmail.com
Thu Feb 8 08:56:23 UTC 2018


Hi Arnout,

<snip>
> >> +# No explicit enable/disable options
> >> +ifeq ($(BR2_PACKAGE_NUMACTL),y)
> >> +LTP_TESTSUITE_DEPENDENCIES += numactl
> >> +else
> >> +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no
> >> +endif
> >> +
> >>  # ltp-testsuite uses <fts.h>, which isn't compatible with largefile
> >>  # support.
> >>  LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> > Thanks for implementing it, LGTM.
> > I just think whether it wouldn't be better to create config option
> > BR2_PACKAGE_LTP_TESTSUITE_LIBNUMA which would select numactl (this would also inform user
> > about this dependency).

>  We generally don't do that unless there is a very good reason, to avoid
> proliferation of Config.in options. In this case, I don't see a very good reason.
OK, thanks for info.
Yesterday we added --without-numa config option to properly disable and there will probably be some more as people demand it. So I thought it would be good for people to be able to choose.


Kind regards,
Petr



More information about the buildroot mailing list