[Buildroot] [PATCH 1/1] busybox: bump to 1.28.0

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Feb 8 22:14:52 UTC 2018


Hello,

On Wed,  7 Feb 2018 09:52:15 -0500, Adam Duskett wrote:

> diff --git a/package/busybox/0002-Makefile.flags-strip-non-l-arguments-returned-by-pkg.patch b/package/busybox/0002-Makefile.flags-strip-non-l-arguments-returned-by-pkg.patch
> index 105626cbe2..4a9881a075 100644
> --- a/package/busybox/0002-Makefile.flags-strip-non-l-arguments-returned-by-pkg.patch
> +++ b/package/busybox/0002-Makefile.flags-strip-non-l-arguments-returned-by-pkg.patch
> @@ -4,6 +4,8 @@ Date: Mon, 25 Nov 2013 22:51:53 +0100
>  Subject: [PATCH] Makefile.flags: strip non -l arguments returned by pkg-config
>  
>  Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> +[Adam Duskett: update for busybox 1.28.0]
> +Signed-off-by: Adam Duskett <aduskett at gmail.com>

Can I ask that you refrain from adding such lines when the patch is
simply refreshed? If you're doing some real changes in the patch to fix
some conflicts, then it's fine to add that. But you seem to be adding
these lines whenever a patch is preserved, even if it has just been
refreshed in terms of line offsets. To me, re-adding a comment + SoB in
such a situation is useless noise.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com



More information about the buildroot mailing list