[Buildroot] [PATCH 1/2] cramfs: change to new site location

Chris Brandt Chris.Brandt at renesas.com
Tue Feb 13 21:08:52 UTC 2018


Hello Thomas,

On Tuesday, February 13, 2018, Thomas Petazzoni wrote:
> > I don't have any big endian systems, so I can't test it either.
> 
> We have a number of Qemu defconfigs, including for big-endian systems
> such as PowerPC. It should be doable to perform a test :)


But....there's more to the story.


I had asked Nicolas if he thought this patch would just magically work 
if I applied it to his current tree.


He had this to say:

On Monday, January 08, 2018, Nicolas Pitre wrote:
> > Could you have a quick look at 0001-endian.patch and see if anything
> > jumps out at you before I try to merge it with you existing repo?
> 
> It is missing the new case where the compressed block length is stored
> as an u16 at the beginning of the block. That's pretty much the only use
> of u16 in the code so easy to locate.
> 
> Also I'd prefer if the swapping functions had the bswap_ prefix rather
> than fix_ which is a bit too generic.
> 
> And would be a good idea to use bswap_32() rather than open coding
> wswap(). You'll also need bswap_16() too anyway.


So, the patch does need a little bit of fixing up.

I could probably rework the patch as Nicolas suggested as long as 
someone else gives it a try. And then, it could get submitted to go back
into the cramfs-tools repo instead of living as a patch in Buildroot forever.


Chris




More information about the buildroot mailing list