[Buildroot] [PATCH] scanpypi: get license names from SPDX database

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jan 1 11:50:26 UTC 2018


Hello,

On Tue, 14 Nov 2017 11:58:56 +0100, yegorslists at googlemail.com wrote:

> +try:
> +    import spdx_lookup as liclookup
> +except ImportError:
> +    # spdx_lookup is not installed
> +    liclookup = None
> +

I understand the idea, but I find it a bit weird to have the script
behave differently depending on whether we have the SDPX Python package
installed or not. Indeed, it may return different license results.

Should we at the very least display a warning when the SDPX package is
not there? Or should we have an option to explicitly select if the SDPX
package should be used or not?

I don't have a strong opinion on this, so if you (and others) believe
that your proposal is good enough, then I'm fine with it.

>          filenames = ['LICENCE', 'LICENSE', 'LICENSE.RST', 'LICENSE.TXT',
> -		     'COPYING', 'COPYING.TXT']
> +                     'COPYING', 'COPYING.TXT']

This is a spurious and not really related change :)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list