[Buildroot] Bugs in patch [v2,7/7] package/mender: new package

Auke Oosterhoff a.oosterhoff at climotion.com
Tue Jan 30 14:27:08 UTC 2018


Hello,

I tested a series of patches which add a new infrastructure for go
packages[1] and patch 7[2] of this series contains a few bugs. The patch
add support for the package Mender.

The MENDER_INSTALL_TARGET_CMDS copies 2 different files to the same
location, which is wrong. Both files should keep their name in target.

+	$(INSTALL) -D -m 0644 package/mender/mender.conf
\+		$(TARGET_DIR)/etc/mender/mender.conf+	$(INSTALL) -D -m 0644
package/mender/tenant.conf \+		$(TARGET_DIR)/etc/mender/mender.conf

And also, the mender binary isn't copied to the target.
I think the content of MENDER_INSTALL_TARGET_CMDS should be extended with:

+	$(INSTALL) -D -m 0755 $(@D)/$(MENDER_BINDIR)/mender
$(TARGET_DIR)/usr/bin/mender

-- 
Met vriendelijke groet,

Auke Willem Oosterhoff


[1]: https://patchwork.ozlabs.org/cover/854079/
[2]: https://patchwork.ozlabs.org/patch/854085/


<http://www.climotion.com/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180130/7e48de62/attachment.html>


More information about the buildroot mailing list