[Buildroot] [PATCH v3 1/1] opentracing-cpp: new package

[Thomas Petazzoni]

Hello,

On Wed, 3 Jan 2018 21:37:03 +0100, Samuel Martin wrote:

> > On the other hand, there doesn't seem to be a real standardization of
> > such options in the CMake world. I.e it's really up to each individual
> > package to obey to BUILD_SHARED_LIBS/BUILD_STATIC_LIBS, and many CMake
> > packages have their own custom options to enable/disable shared/static
> > library build.
> >
> > But I guess for the sake of consistency pkg-cmake.mk should also pass
> > BUILD_STATIC_LIBS, and we should accordingly cleanup the CMake packages
> > that rely on BUILD_SHARED_LIBS/BUILD_STATIC_LIBS to not pass them
> > explicitly, and rely on what the pkg-cmake infra is doing.  
> 
> Adding BUILD_STATIC_LIBS will make thing a bit nicer (at least
> symetric), though it is not standard in any way, which means some
> projects may choose another name for a similar option and there is not
> much we can do about this.
> 
> BTW, some projects still seems ignoring the existence of the
> BUILD_SHARED_LIBS variable since they add a similar option with a
> different name.
> 
> 
> [1] https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior

So BUILD_SHARED_LIBS is somewhat standardized by CMake, but not
BUILD_STATIC_LIBS.

If that's the case, then we should not handle BUILD_STATIC_LIBS in
pkg-cmake.mk, contrary to what I said previously. And we should add a
comment explaining this in pkg-cmake.mk.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com