[Buildroot] [PATCH v4 2/2] opentracing-cpp: new package

Jan Heylen heyleke at gmail.com
Fri Jan 5 12:57:36 UTC 2018


Hello,

On Wed, Jan 3, 2018 at 9:40 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Wed,  3 Jan 2018 21:09:25 +0100, Jan Heylen wrote:
>
>> diff --git a/package/opentracing-cpp/Config.in b/package/opentracing-cpp/Config.in
>> new file mode 100644
>> index 0000000..f13d21b
>> --- /dev/null
>> +++ b/package/opentracing-cpp/Config.in
>> @@ -0,0 +1,16 @@
>> +config BR2_PACKAGE_OPENTRACING_CPP
>> +     bool "opentracing-cpp"
>> +     depends on BR2_INSTALL_LIBSTDCPP
>> +     depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
>> +     depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
>> +     depends on !BR2_m68k_cf # exception_ptr
>
> So exception_ptr is not available on m68k coldfire, regardless of the
> gcc version ?
>
> If so, we perhaps want to introduce something like:
>
> config BR2_TOOLCHAIN_HAS_EXECPTION_PTR
>         bool
>         default y
>         depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735
>         depends on !BR2_m68k_cf
>
> but please confirm first that there really is something special about
> m68k coldfire.

Done by experiment, in V6 added BR2_m68k_cf to
BR2_TOOLCHAIN_HAS_GCC_BUG_64735. See V6 op this patchset.

>
>> +     help
>> +       OpenTracing API for C++
>> +
>> +       http://opentracing.io
>> +
>> +comment "opentracing-cpp needs a toolchain w/ C++11"
>
> This should be:
>
>         opentracing-cpp needs a toolchain w/ C++, gcc >= 4.8"

Done in V6.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com



More information about the buildroot mailing list