[Buildroot] [PATCH v2 1/1] python-xlib: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jan 6 14:13:08 UTC 2018


Hello,

On Fri,  5 Jan 2018 13:13:07 -0800, Joseph Kogut wrote:
> Thanks for the review, Yegor!
> 
> Changes since v1:
> - added runtime tag to python-six Config dependency
> - remove unneeded command and newline from python-xlib.hash
> - added host-python-setuptools-scm to build dependencies
> - removed setup.py patch

This personal message and changelog should have gone...

> 
> Signed-off-by: Joseph Kogut <joseph.kogut at gmail.com>
> Reviewed-by: Yegor Yefremov <yegorslists at googlemail.com>
> ---

... here, so that Git doesn't include it as part of the commit log.
Indeed, we don't need to keep such details in the Git history (but they
are very useful to have during the patch review process).

> +PYTHON_XLIB_VERSION = 0.21
> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
> +PYTHON_XLIB_SETUP_TYPE = setuptools
> +PYTHON_XLIB_LICENSE = LGPL-2.0+

The license is in fact LGPL-2.1+, so I've fixed that and applied your
patch to the master branch.

Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list