[Buildroot] [PATCH v2 1/1] python-xlib: new package

Yegor Yefremov yegorslists at googlemail.com
Sun Jan 7 10:06:45 UTC 2018


Hello Joseph,

On Sun, Jan 7, 2018 at 3:48 AM, Joseph Kogut <joseph.kogut at gmail.com> wrote:
> Hello,
>
> On Sat, Jan 6, 2018 at 6:13 AM, Thomas Petazzoni
> <thomas.petazzoni at free-electrons.com> wrote:
>>
>> This personal message and changelog should have gone...
>>
>>>
>>> Signed-off-by: Joseph Kogut <joseph.kogut at gmail.com>
>>> Reviewed-by: Yegor Yefremov <yegorslists at googlemail.com>
>>> ---
>>
>> ... here, so that Git doesn't include it as part of the commit log.
>> Indeed, we don't need to keep such details in the Git history (but they
>> are very useful to have during the patch review process).
>>
>>> +PYTHON_XLIB_VERSION = 0.21
>>> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
>>> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
>>> +PYTHON_XLIB_SETUP_TYPE = setuptools
>>> +PYTHON_XLIB_LICENSE = LGPL-2.0+
>>
>> The license is in fact LGPL-2.1+, so I've fixed that and applied your
>> patch to the master branch.
>
> Ah, thanks for the fixup. I'll keep that in mind next time.
>
>> Thanks for your contribution!
>
> Thanks for all your support!

Btw. have you ever tried utils/scanpypi (see "17.8.3. Generating a
python-package from a PyPI repository" for the reference)?

Yegor



More information about the buildroot mailing list