[Buildroot] [PATCH v6 2/4] pkg-cmake: add note on BUILD_STATIC_LIBS

[Thomas Petazzoni]

Hello,

On Thu,  4 Jan 2018 13:28:29 +0100, Jan Heylen wrote:

> +#
> +# Note:
> +# BUILD_SHARED_LIBS is a cmake internal variable,
> +# BUILD_STATIC_LIBS is not standard in any way, which means some
> +# projects may choose another name for a similar option and there is not
> +# much we can do about this.
> +# see: https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior
> +#

I've applied, after rewording this a bit differently:

+#
+# - We are passing BUILD_SHARED_LIBS because it is documented as a
+#   standard CMake variable to control the build of shared libraries
+#   (see https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior)
+# - We are not passing BUILD_STATIC_LIBS because it is *not*
+#   documented as a standard CMake variable. If a package supports it,
+#   it must handle it explicitly.
+#

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com