[Buildroot] [PATCH] package/bash-completion: new package

[Romain Naour]

Hi Baruch,

Le 11/01/2018 à 12:34, Baruch Siach a écrit :
> Hi Romain,
> 
> On Thu, Jan 11, 2018 at 12:17:26PM +0100, Romain Naour wrote:
>> From: Jeremy Rosen <jeremy.rosen at smile.fr>
>>
>> Signed-off-by: Jeremy Rosen <jeremy.rosen at smile.fr>
>> Signed-off-by: Romain Naour <romain.naour at smile.fr>
>> ---
> 
> [...]
> 
>> +################################################################################
>> +#
>> +# bash-completion
>> +#
>> +################################################################################
>> +
>> +BASH_COMPLETION_VERSION = 2.7
>> +BASH_COMPLETION_SITE = https://github.com/scop/bash-completion/releases/download/$(BASH_COMPLETION_VERSION)
>> +BASH_COMPLETION_SOURCE = bash-completion-$(BASH_COMPLETION_VERSION).tar.xz
>> +BASH_COMPLETION_LICENSE = GPL-2.0+
>> +BASH_COMPLETION_LICENSE_FILES = COPYING
>> +
>> +define BASH_COMPLETION_INSTALL_TARGET_CMDS
>> +	echo ". /usr/share/bash-completion/bash_completion" > $(TARGET_DIR)/etc/bash_completion
>> +endef
> 
> How do you install the completion scripts?

You're right, I wanted to use BASH_COMPLETION_INSTALL_TARGET_HOOKS here and let
the autotools infra install the completion scripts...

I'll resend a v2.

Also, I added BASH_COMPLETION_INSTALL_STAGING = YES since bash-completion
provide a .pc file.

Thanks for your review.

Best regards,
Romain

> 
> baruch
>