[Buildroot] [PATCH] package/bash: add /bin/bash to /etc/shells
Romain Naour
romain.naour at smile.fr
Fri Jan 12 09:06:45 UTC 2018
Hi Yann, Thomas,
Le 12/01/2018 à 09:59, Thomas Petazzoni a écrit :
> Hello,
>
> On Thu, 11 Jan 2018 18:13:57 +0100, Yann E. MORIN wrote:
>
>> I would do:
>>
>> grep -E '^/bin/bash$' $(TARGET_DIR)/etc/shells >/dev/null 2>&1 \
>
> grep -q ?
>
>> || echo "/bin/bash" >> $(TARGET_DIR)/etc/shells
>>
>> That way, we only install it if not already present.
>
> Otherwise, yes, agreed.
Ok, I'll fix this.
But the same issue should happen with other shell (not tested though).
For example, it ash (busybox) is not the default shell and a user use it to
login, it will be rejected.
So busybox should also add /bin/ash in /etc/shells.
Thoughts?
Best regards,
Romain
>
> Thomas
>
More information about the buildroot
mailing list