[Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
Yann E. MORIN
yann.morin.1998 at free.fr
Fri Jan 12 17:39:53 UTC 2018
Thomas, All,
On 2018-01-12 10:02 +0100, Thomas Petazzoni spake thusly:
> On Thu, 11 Jan 2018 18:31:04 +0100, Yann E. MORIN wrote:
> > > + # currently not observed by systemd
> > > + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
> >
> > Why not:
> > depends on !BR2_INIT_SYSTEMD
> >
> > because this is really want we want to express: this is not compatible
> > with systemd...
>
> No, what we really want to express is that
> BR2_TARGET_GENERIC_GETTY_{TERM,OPTIONS} are only handled in the busybox
> code and sysvinit code. It's not so much that they are not compatible
> with systemd, it is that only busybox and sysvinit observe those
> options.
Then change the title and commit to something like:
system: only expose getty option for busybox and sysvinit
Only busybox and sysvinit handle those options; the other init
systems do not.
So, protect those options behind appropriate dependencies on
busybox or sysvinit.
Fixes #10301.
And then you can add my:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list