[Buildroot] [PATCH 1/1] kconfig: Apply upstream nconfig ncurses/ncursesw fix

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jan 15 20:37:06 UTC 2018


Hello,

On Sun, 14 Jan 2018 09:28:07 -0800, Guillermo A. Amaral wrote:
> Buildroot's "make nconfig" command stopped working a while ago on all my
> Gentoo systems. Running the command would result in a crash.
> 
> I found that the issue was caused by lxdialog's cflags which are also
> used to build nconfig; It would detect *ncursesw* and turn on WIDECHAR
> support -- but the Makefile would still link to plain *ncurses* while
> building nconfig (which was built without WIDECHAR support).
> 
> This would cause a crash after using *wattrset* on a WINDOW instance.
> WIDECHAR *wattrset* would try to set the _color member in the WINDOW
> struct which does not exist in the NON-WIDECHAR ncurses instance. It
> would end up clobbering data outside the struct (usually _line entries).
> 
> I found an upstream patch fixing the issue, so I'm applying it to
> Buildroot's kconfig.
> 
> Signed-off-by: Guillermo A. Amaral <g at maral.me>
> ---
>  support/kconfig/Makefile                           |  3 +-
>  ...onfig-nconfig-fix-multi-byte-UTF-handling.patch | 45 ++++++++++++++++++++++
>  support/kconfig/patches/series                     |  1 +
>  3 files changed, 48 insertions(+), 1 deletion(-)
>  create mode 100644 support/kconfig/patches/18-kconfig-nconfig-fix-multi-byte-UTF-handling.patch

I've applied after tweaking a bit the commit title ("support/kconfig"
instead of "kconfig") and the commit log (using the singular first
person is not very common).

Thanks a lot for this contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list