[Buildroot] [PATCH 1/2] ltp-testsuite: disable numa tests

[Baruch Siach]

Hi Petr,

On Fri, Jan 26, 2018 at 03:37:00PM +0200, Baruch Siach wrote:
> On Fri, Jan 26, 2018 at 12:17:04PM +0100, Petr Vorel wrote:
> > > The LTP_CHECK_SYSCALL_NUMA autoconf macro uses AC_RUN_IFELSE when it
> > > detects the numaif.h header. This is incompatible with cross
> > > compilation.
> > Is it really about cross compilation or about out-of-tree building?
> 
> As I understand this is about cross compilation, which is inherently 
> incompatible with AC_RUN_IFELSE[1].
> 
> > Any idea how to fix it in upstream?

Thinking about this a little more, I think you can make the test into a 
compile time test instead of run-time with something like:

#if LIBNUMA_API_VERSION < 2
#error libnuma API version too old
#endif

baruch

> > As we test both cross compilation and out out-of-tree
> > compilation with travis:
> > https://travis-ci.org/linux-test-project/ltp/builds/333338092
> > 
> > * aarch64 cross compilation
> > https://travis-ci.org/linux-test-project/ltp/jobs/333338103
> > * arm cross compilation
> > https://travis-ci.org/linux-test-project/ltp/jobs/333338102
> > * native out-of-tree compilation
> > https://travis-ci.org/linux-test-project/ltp/jobs/333338101
> 
> Do you nave libnuma (numactl) installed in these tests? If not, the 
> AC_RUN_IFELSE test is skipped. You can reproduce this build failure in 
> Buildroot by first building the numactl package, and then ltp-testsuite.
> 
> [1] https://www.gnu.org/software/autoconf/manual/autoconf.html#Runtime
> 
> > > Fixes:
> > > http://autobuild.buildroot.net/results/21a/21a6eeddbf5ccffc34c38527d0807305a5eb3917/
> > > http://autobuild.buildroot.net/results/fc0/fc01921e8e8e1ea100461b29137c4219e6686c58/
> > > http://autobuild.buildroot.net/results/962/96285d154abd65838ff5c66e96db309d9ac26c80/
> > 
> > > Cc: Petr Vorel <petr.vorel at gmail.com>
> > > Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> > > ---
> > >  package/ltp-testsuite/ltp-testsuite.mk | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > > diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
> > > index 87854568d8a6..28dc24749ec8 100644
> > > --- a/package/ltp-testsuite/ltp-testsuite.mk
> > > +++ b/package/ltp-testsuite/ltp-testsuite.mk
> > > @@ -56,7 +56,8 @@ LTP_TESTSUITE_CONF_ENV += \
> > >  	CFLAGS="$(LTP_TESTSUITE_CFLAGS)" \
> > >  	CPPFLAGS="$(LTP_TESTSUITE_CPPFLAGS)" \
> > >  	LIBS="$(LTP_TESTSUITE_LIBS)" \
> > > -	SYSROOT="$(STAGING_DIR)"
> > > +	SYSROOT="$(STAGING_DIR)" \
> > > +	have_numa_headers=no
> > 
> > >  # Requires uClibc fts and bessel support, normally not enabled
> > >  ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
> > 
> > Acked-by: Petr Vorel <petr.vorel at gmail.com>

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -