[Buildroot] [PATCH 2/2] ltp-testsuite: drop redundant arch dependency entries
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sat Jan 27 22:07:07 UTC 2018
Hello,
On Fri, 26 Jan 2018 13:03:18 +0200, Baruch Siach wrote:
> BR2_TOOLCHAIN_HAS_SYNC_4 is enabled for all these architectures except
> arc. There is no need to list them explicitly.
>
> Cc: Romain Naour <romain.naour at gmail.com>
> Cc: Petr Vorel <petr.vorel at gmail.com>
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> ---
> package/ltp-testsuite/Config.in | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in
> index 4c00e40f330e..711c859e6caf 100644
> --- a/package/ltp-testsuite/Config.in
> +++ b/package/ltp-testsuite/Config.in
> @@ -5,11 +5,6 @@ config BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS
> # provided in ltp-testsuite
> default y if BR2_TOOLCHAIN_HAS_SYNC_4
> default y if BR2_arc
> - default y if BR2_i386
> - default y if BR2_powerpc
> - default y if BR2_powepc64
> - default y if BR2_powerpc64le
> - default y if BR2_x86_64
Is this really a correct patch ? It's not because
BR2_TOOLCHAIN_HAS_SYNC_4 already covers
i386/powerpc/powerpc64/powerpc64le/x86_64 that it makes sense to use
BR2_TOOLCHAIN_HAS_SYNC_4 instead.
What if an architecture gets added to BR2_TOOLCHAIN_HAS_SYNC_4, but
isn't supported by ltp-testsuite ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list