[Buildroot] [PATCH] package/squid: fix automake breakage

[Jean-François Têtu]

Hello Arnout,

On Wednesday, July 11, 2018 8:47:23 PM, Jean-François Têtu wrote:
> Hello!
> 
> On Wednesday, July 11, 2018 5:08:13 PM, Arnout Vandecappelle wrote:
>> On 11-07-18 21:34, Jean-François Têtu wrote:
>>> Much like e27ccbabc1, the recent bump in automake causes a build error.
>>> If the host automake is not the same version as the one used to generate
>>> the squid package, the build fails while building the copy of libltdl
>>> included in the package.
>>> 
>>> This happens regardless of the Buildroot automake version since the
>>> included library is not reconfigured properly. The previous fix set the
>>> ACLOCAL and AUTOMAKE variables to the Buildroot generated aclocal and
>>> automake thereby ensuring that the subpackage would build correctly.
>>> What is needed is to make sure that both the squid configure script and
>>> the libltdl configure script are reconfigured following a change to
>>> either configure.ac files.
>>> 
>>> This commit adds an option passed to autoreconf which ensures both
>>> configure scripts are regenerated with Buildroot's autotools.
>> 
>> Nicely found!
>> 
> 
> Thanks :)
> 
>> However, have you also looked into the option of using Buildroot's libtool
>> instead of the bundled libltdl? If that doesn't work for some reason, I'd like
>> to add it in the commit log so a future developer who wants to give it go can
>> see what has been tried already.
>> 
> 
> I can look into how we could pull in Buildroot's libltdl because
> currently, Squid relies on its bootstrap script to pull in libtldl from
> the machine that is generating the package. Maybe this could be done
> with the autotools instead of the bootstrap?
> 

>From what I understand, the packaged libltdl in Squid comes from its
bootstrap. This pulls in libltdl from the host's libtool during the
libtoolize step.  Currently, the latest version of libtool is 2.4.6.
This version was itself created using automake 1.15. Ultimately, this
means that the included libltdl in Squid is made to be built with
automake 1.15. Unless its forcibly reconf'd with automake 1.16.1.

To fix this issue would require a version of libtool made with automake
1.16.1.  This version currently does not exist as the latest version of
libtool dates back from 2015-02-15, just after the release of automake 
1.15 on 2015-01-05.

In order to build Squid in a sustainable manner, the autoreconf flags
are needed, at least until libtool is bumped.

Would you like me to add a note reflecting this in the commitmsg?

Regards,

--
Jean-François Têtu