[Buildroot] 答复: patch: fix wrong sysroot path when given rsdk toolchain

陈小刚 shawn_chen at realsil.com.cn
Fri Jul 20 08:21:24 UTC 2018


Hi Thomas,

Thanks for reminding, I'm tweaking my work environment to use git-send-email, it takes a while.
I uploaded the toolchain to Google drive for your test, here is the link:
https://drive.google.com/open?id=1vkrGPUWbzIGMWMZb8DypyK1VIynnbqnn
And a defconfig for your reference:
https://drive.google.com/open?id=1J8ksyWcyXEBfEy0EKrMuH1Zyiif25HrR

In shell you can mimic the buildroot find toolchain sysroot as this:

$ readlink -f $(LANG=C ..../rsdk-6.4.1-5281-EL-4.9-u1.0-m32fut-180611/bin/rsdk-linux-gcc -print-file-name=libc.a)|sed -r -e 's:(usr/)?lib(32|64)?([^/]*)?/([^/]*/)?libc\.a::'

Regards
Shawn Chen

-----邮件原件-----
发件人: Thomas Petazzoni [mailto:thomas.petazzoni at bootlin.com] 
发送时间: 2018年7月19日 21:33
收件人: 陈小刚
抄送: buildroot at buildroot.org; Thomas De Schampheleire
主题: Re: [Buildroot] patch: fix wrong sysroot path when given rsdk toolchain

Hello Shawn,

Thanks for your patch, and for contributing to Buildroot!

On Thu, 19 Jul 2018 09:10:03 +0000, 陈小刚 wrote:

> The attachment is a patch that fixes a Realtek toolchain that has a
> sysroot path of ‘mips-linux-uclibc’, this causes the buildroot
> recognizes the sysroot as ‘mips-linux-uc’ by the sed operation, and
> then the external toolchain setup is failed. Adding a ‘/’ in the sed
> re expression avoids the wrong substitution, other toolchains like
> linaro arm toolchain are tested ok to ensure no side effect is
> induced, please help review and apply this patch, thanks.

Would it be possible to get access to this Realtek toolchain? I'd like
to check the behavior, and understand a bit more the issue, because it
looks a bit suspicious/strange.

The sed expression is supposed to replace:

  /path/to/sysroot/usr/lib/libc.a

by:

  /path/to/sysroot/

So I don't quite see how the ending "libc" in mips-linux-uclibc can
affect this.

Also, for your next patches, could you send them with the patch
description in the commit log (currently your commit log is just
"IPCSDK-6460", which is not very useful) ? Also, they should be sent
with "git send-email", so that the patch is inline.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

------Please consider the environment before printing this e-mail.


More information about the buildroot mailing list