[Buildroot] [PATCH 2/4] package/transmission: fix systemd support
Peter Korsgaard
peter at korsgaard.com
Mon Jun 11 21:15:01 UTC 2018
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:
> Hello,
> On Wed, 2 May 2018 08:05:38 +0200, Bernd Kuhls wrote:
>> Patch 0005-libsystemd.patch backports an upstream commit which renames
>> the systemd configure option.
>>
>> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
>> ---
>> package/transmission/transmission.mk | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> The order of the patches in your patch series is not very good. Indeed,
> patches 2/4, 3/4 and 4/4 are fixing problems that exist *today* in
> Buildroot, with the current version of transmission being packaged.
> Therefore, they should appear first in the series, before the bump.
> This is even more relevant right now, as patches 2/4, 3/4 and 4/4
> should be applied to master, while patch 1/4 is only for next.
> So, I've applied this patch to master, after fixing the commit log to
> mention 0006-libsystemd.patch, since the patch is named this way in
> master.
Committed to 2018.02.x, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list