[Buildroot] [PATCH v3,2/2] librsvg: bump to version 2.42.5

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Jun 12 20:42:55 UTC 2018


Hello,

On Tue, 12 Jun 2018 22:18:50 +0200, Peter Korsgaard wrote:

>  >> This also causes a number of issues for host-librsvg (which is a
>  >> dependency of libgtk3 and midori) when building for architectures not
>  >> supported by rust:
>  >>   
>  > The issue isn't related to libgtk3 and midori as this build fails (
>  > http://autobuild.buildroot.net/results/f33/f335ed517b402c094ed3b10a3da4cdc23620dbd6/defconfig)
>  > even if these packages are not selected.  
> 
> It is a bit more tricky than that because it can also be about
> host-libgtk3. For this configuration it is adwaita-icon-theme which
> pulls in host-libgtk3 -> host-librsvg -> host-cargo -> host-rustc

I think there is an issue in how we handle rust in fact. Indeed, the
BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS option indicates if the Rust
compiler is capable to act as a cross-compiler for the selected target.

But we haven't accounted for the fact that the Rust compiler can also
do native builds, like it does for host-librsvg. In the case of native
builds, we don't care whether Rust has support for the target
architecture: we care about it having support for the host architecture.

So basically, the fact that Rust is both a native compiler and a
cross-compiler is not properly accounted today.

Perhaps we need to have two separate
BR2_PACKAGE_HOST_RUSTC_something_ARCH_SUPPORTS options, to use
depending on whether you need Rust support for the target, or Rust
support for the host ?

Eric, what do you think ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list