[Buildroot] [PATCH v3] libusb: add an option to compile examples

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Jun 17 13:13:45 UTC 2018


Hello,

On Mon, 11 Jun 2018 09:47:50 -0400, Gaël PORTAY wrote:

> +ifeq ($(BR2_PACKAGE_LIBUSB_EXAMPLES),y)
> +LIBUSB_CONF_OPTS += --enable-examples-build
> +define LIBUSB_INSTALL_TARGET_EXAMPLES
> +	for example in listdevs xusb fxload hotplugtest testlibusb dpfp dpfp_threaded sam3u_benchmark ; do \

As I said in a review of an earlier version, you should use a make loop
instead of a shell loop. One benefit of make loops is that they bail
out if one iteration of the loop fails. A shell loop doesn't, and
continues with the next iterations.

> +		cp -dpfr $(@D)/examples/$${example} $(TARGET_DIR)/usr/bin; \

This should have use $(INSTALL) -D -m 0755 and a full destination path.

I've fixed both issues and applied.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list