[Buildroot] Start denying fuzz in patches?

Peter Korsgaard peter at korsgaard.com
Tue Mar 13 21:18:46 UTC 2018


>>>>> "Adam" == Adam Duskett <aduskett at gmail.com> writes:

Hi,


 > The patch tool will apply patches by default with "fuzz," which is where if the
 > hunk context isn't present but what is there is close enough, it will force the
 > patch to be applied anyways.

 > While this is useful when there are just whitespace changes, when applied to
 > actual source code, it is possible for a patch applied with fuzz to produce
 > broken code which still compiles.

 > I propose that Buildroot take the initiative to start cleaning up the current
 > patches, and in the future start denying updates/new packages with patches that
 > apply with fuzz.

I agree that this could be a nice goal for patches we carry directly in
Buildroot. We may still need to handle fuzz for patches that we download
from somewhere.

Did you run into any specific issue with one of our patches, or what
triggered your mail?

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list