[Buildroot] [RFC] how to deal with a dependency on configure in a "Makefile"
Charles Hardin
charles.hardin at storagecraft.com
Wed Mar 14 16:48:50 UTC 2018
And finally figured it out - we had incorporated a patch a while back to get the exec_prefix to match
e2fsprogs and of course the patches and changes configure and configure.ac which triggers the whole
mess - so, definitely on our end and nothing upstream.
Sorry for the bother, and the patch is below in case in matters.
Charles
packages/xfsprogs: patch the exec_prefix to be the same as e2fsprogs
Since e2fsprogs get installed into /bin to override busybox, so do
the same thing for xfsprogs.
diff -Naur xfsprogs-3.1.11.orig/configure xfsprogs-3.1.11/configure
--- xfsprogs-3.1.11.orig/configure 2016-01-03 19:27:44.603418507 +0000
+++ xfsprogs-3.1.11/configure 2016-01-03 19:26:16.029757743 +0000
@@ -10036,8 +10036,8 @@
# case. If the user choses a different prefix assume he just wants
# a local install for testing and not a system install.
#
-case $exec_prefix:$prefix in
-NONE:NONE | NONE:/usr | /usr:*)
+case $cross_compiling:$exec_prefix:$prefix in
+no:NONE:NONE | no:NONE:/usr | no:/usr:*)
root_sbindir='/sbin'
root_libdir="/${base_libdir}"
;;
diff -Naur xfsprogs-3.1.11.orig/configure.ac xfsprogs-3.1.11/configure.ac
--- xfsprogs-3.1.11.orig/configure.ac 2016-01-03 19:28:02.258949863 +0000
+++ xfsprogs-3.1.11/configure.ac 2016-01-03 19:25:45.918554215 +0000
@@ -64,8 +64,8 @@
# case. If the user choses a different prefix assume he just wants
# a local install for testing and not a system install.
#
-case $exec_prefix:$prefix in
-NONE:NONE | NONE:/usr | /usr:*)
+case $cross_compiling:$exec_prefix:$prefix in
+no:NONE:NONE | no:NONE:/usr | no:/usr:*)
root_sbindir='/sbin'
root_libdir="/${base_libdir}"
;;
On Mar 13, 2018, at 10:29 PM, Charles Hardin <charles.hardin at storagecraft.com<mailto:charles.hardin at storagecraft.com>> wrote:
Sorry, I checked the tarball the time stamps fit, but something wonky happens during the build I cann’t figure out yet what triggers the make rules ... I’ll drop the configure.ac but this is really just a - I have no clue and was wondering if anyone else has seen this anywhere else.
Assume this is why I never make a circle between the makefiles and the autoconf, it is a headache when it fires.
Sent from my iPhone
On Mar 13, 2018, at 10:19 PM, Baruch Siach <baruch at tkos.co.il<mailto:baruch at tkos.co.il>> wrote:
Hi Charles,
On Tue, Mar 13, 2018 at 11:43:12PM +0000, Charles Hardin wrote:
I went more by the build output show the make invocation of configure during
"build" stage in the log.
./configure $$LOCAL_CONFIGURE_OPTIONS
Unfortunately, this was a transient build on a VM and I didn't stat the
files. In the meantime, we are going to try this for a bit and see if
anything changes.
You can manually extract the xfsprogs tarball and stat the files directly.
commit d25e2a8f163c8c77055c3c7c8e89d65ec09e0f8e (HEAD -> master)
Author: Charles Hardin <charles.hardin at storagecraft.com<mailto:charles.hardin at storagecraft.com>>
Date: Tue Mar 13 16:39:23 2018 -0700
xfsprogs: force touch the order of the configuration files
The Makefile can cause a rerun of the autoconf which could
occur and use the host tools which is very annoying, so touch
the files in the order expected so that the configure scripts
hopefully run in the order intended and prevent any trips
thru autoconf.
Signed-off-by: Charles Hardin <charles.hardin at storagecraft.com<mailto:charles.hardin at storagecraft.com>>
diff --git a/package/xfsprogs/xfsprogs.mk b/package/xfsprogs/xfsprogs.mk
index aa5c37ed8d..39fa3821ff 100644
--- a/package/xfsprogs/xfsprogs.mk
+++ b/package/xfsprogs/xfsprogs.mk
@@ -22,4 +22,13 @@ XFSPROGS_CONF_OPTS = \
XFSPROGS_INSTALL_TARGET_OPTS = DIST_ROOT=$(TARGET_DIR) install
+define XFSPROGS_AVOID_AUTORECONF_HOOK
+ find $(@D) -name aclocal.m4 -exec touch '{}' \;
+ find $(@D) -name config-h.in -exec touch '{}' \;
+ find $(@D) -name configure.ac -exec touch '{}' \;
I don't think want to update the configure.ac timestamp.
baruch
+ find $(@D) -name configure -exec touch '{}' \;
+ find $(@D) -name Makefile.in -exec touch '{}' \;
+endef
+XFSPROGS_PRE_CONFIGURE_HOOKS += XFSPROGS_AVOID_AUTORECONF_HOOK
+
$(eval $(autotools-package))
________________________________
From: Baruch Siach <baruch at tkos.co.il<mailto:baruch at tkos.co.il>>
Sent: Tuesday, March 13, 2018 2:01:50 PM
To: Charles Hardin
Cc: buildroot at buildroot.org<mailto:buildroot at buildroot.org>
Subject: Re: [Buildroot] [RFC] how to deal with a dependency on configure in a "Makefile"
Hi Charles,
On Tue, Mar 13, 2018 at 07:27:30PM +0000, Charles Hardin wrote:
So, we hit this problem that took me a while to figure out - but, it seems
to be that
xfsprogs has this bit in the Makefile when it extracts:
configure: configure.ac
$(LIBTOOLIZE_BIN) -c $(LIBTOOLIZE_INSTALL) -f
cp include/install-sh .
aclocal -I m4
autoconf
include/builddefs: configure
./configure $$LOCAL_CONFIGURE_OPTIONS
And the timestamps on the tar extraction end up in a race so that this gets invoked
during the “build” - so, I tried looking at other packages to deal with this and I can
just touch configure on a PRE_CONFIGURE hook to get it to bounce forward or
I could set AUTORECONF on xfsprogs. But, is there a preferred method to deal
with this?
Which version of xfsprogs do you use?
Here is what I get for the current master branch xfsprogs tarball
(xfsprogs-4.15.1.tar.xz):
$ stat -c '%n: %y' configure configure.ac
configure: 2018-02-27 04:05:49.000000000 +0200
configure.ac: 2018-02-27 04:04:50.000000000 +0200
'configure' is newer than 'configure.ac', so the 'configure' generation rule
should not trigger.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il<mailto:baruch at tkos.co.il> - tel: +972.2.679.5364, http://www.tkos.co.il -
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180314/3fbd1b5a/attachment-0002.html>
More information about the buildroot
mailing list