[Buildroot] [PATCH v4 1/9] Makefile, skeleton: move the host skeleton logic to host-skeleton package

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Mar 24 15:37:16 UTC 2018


Hello,

On Sat, 24 Mar 2018 16:28:52 +0100, Yann E. MORIN wrote:

> > +ifneq ($(1),host-skeleton)
> > +$(2)_DEPENDENCIES += host-skeleton
> > +endif  
> 
> In fact, I'm not too sure I should have given my Reviewed-by tag,
> because now the graph-depends are all borked: all packages have a
> dependency arrow toward host-skeleton.

It is not borked, that's completely correct. Maybe not pretty and
convenient, but definitely not "borked".

> What about adding host-skeleton as a dependency to skeleton-init-common
> and skeleton-custom only?

Really feels wrong to me: there is absolutely no reason for
skeleton-init-common and skeleton-custom to depend on host-skeleton.

> Or we can also just add host-skeleton as a special case in
> support/scripts/graph-depends...

That feels like a much better solution to me. We already do that for
the skeleton anyway. Would that be OK for you?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list