[Buildroot] [PATCH 07/15 v4] fs: use a per-rootfs fakeroot script

Peter Korsgaard peter at korsgaard.com
Sat Mar 31 17:50:15 UTC 2018


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > ... and locate that script in a per-rootfs directory.
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
 > Cc: Arnout Vandecappelle <arnout at mind.be>
 > ---
 >  fs/common.mk | 6 +++---
 >  1 file changed, 3 insertions(+), 3 deletions(-)

 > diff --git a/fs/common.mk b/fs/common.mk
 > index eebe83d6e5..db4f8c23ad 100644
 > --- a/fs/common.mk
 > +++ b/fs/common.mk
 > @@ -28,7 +28,6 @@
 >  # macro will automatically generate a compressed filesystem image.
 
 >  FS_DIR = $(BUILD_DIR)/buildroot-fs
 > -FAKEROOT_SCRIPT = $(FS_DIR)/fakeroot.fs
 >  FULL_DEVICE_TABLE = $(FS_DIR)/device_table.txt
 >  ROOTFS_DEVICE_TABLES = $(call qstrip,$(BR2_ROOTFS_DEVICE_TABLE) \
 >  	$(BR2_ROOTFS_STATIC_DEVICE_TABLE))
 > @@ -76,10 +75,11 @@ ROOTFS_$(2)_COMPRESS_CMD = xz -9 -C crc32 -c
 >  endif
 
 >  $$(BINARIES_DIR)/rootfs.$(1): ROOTFS=$(2)
 > +$$(BINARIES_DIR)/rootfs.$(1): FAKEROOT_SCRIPT=$$(ROOTFS_$(2)_DIR)/fakeroot

It wasn't quite clear to me why we had to go through the hoops to ensure
ROOTFS didn't leak but we don't do it for FAKEROOT_SCRIPT, so I've
extended the commit message a bit.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list