[Buildroot] [PATCH 13/15 v4] fs: run packages' filesystem hooks in a copy of target/

Arnout Vandecappelle arnout at mind.be
Sat Mar 31 21:09:43 UTC 2018



On 31-03-18 22:27, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
> 
> Hi,
> 
>  >> mkdir -p $(FS_DIR)
>  >> +	rsync -au $(BASE_TARGET_DIR)/ $(TARGET_DIR)
> 
>  >  This would benefit a lot from using the --link-dest= that we will also use in
>  > PPS, in my opinion.
> 
> Wouldn't hard links be potentially dangerous - E.G. in case a script
> appends to a file.

 If this is a script that runs in the context of building a package, then the
hard link does exactly what we want.

 If it is a script that runs in the context of rootfs generation, you have a point.

 If your target is a bit large and you have several filesystems to support, I
expect that making all these copies is really going to hit you in build time for
a simple package rebuild. Of course, we can fix that problem when it happens.

 Regards,
 Arnout


> As I mentioned in my comments to patch 15, we could as well use cp
> instead of rsync as we throw away the copy after each build.

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list