[Buildroot] [PATCH] host-mkpasswd: fix crash on Fedora 28 build host

Yann E. MORIN yann.morin.1998 at free.fr
Wed May 2 21:04:27 UTC 2018


Arnout, All,

On 2018-05-02 22:38 +0200, Arnout Vandecappelle spake thusly:
> On 02-05-18 20:23, Stefan Becker wrote:
> > On Wed, May 2, 2018 at 8:57 PM Yann E. MORIN <yann.morin.1998 at free.fr
> > <mailto:yann.morin.1998 at free.fr>> wrote:
> >     But what if the libxcrypt package is not installed? Since crypt is only
> >     optional in POSIX, there is no guarantee that libxcrypt is even present
> >     on a system, especially now that glibc has decided to no longer provide
> >     it by default, and given that even --enable-obsolete-crypt does not even
> >     declare _XOPEN_CRYPT...
> >  
> > If crypt() is provided by libxcrypt instead of glibc, then this should be
> > automatically handled by package dependencies, i.e.
[--SNIP--]
>  And in pre-F28 this header will be provided by glibc-devel, right?

At least it is so in a debian-based distro, yes.

>  But so in practice we can assume that crypt.h is always present, so why not
> include it unconditionally?
> 
>  BTW, how is this solved in upstream whois?

Sufficiently good that we may want to update?

When we included mkpasswd, we did not have the whois package in
Buildroot. Now we have it, but there is no host variant.

Maybe it is time to add host-whois, that installs mkpasswd, and then
ditch our bundled copy of mkpasswd?

rc1 is really close now (Peter said next weekend), so it is a bit late
to switch, maybe... :-/

In the meantime, as I already said, this patch is good-enough to go
as-is for now.

If we get a better solution after the release, we can backport it if
that makes sense. But until then...

Regards,
Yann E. MORIN.

> > ...
> > $ rpm -q --provides libxcrypt-devel
> > libxcrypt-devel = 4.0.0-5.fc28
> > libxcrypt-devel(x86-64) = 4.0.0-5.fc28
> > pkgconfig(libxcrypt) = 4.0.0
> > $ rpm -q --whatrequires 'libxcrypt-devel(x86-64)'
> > glibc-devel-2.27-8.fc28.x86_64
> > 
> > So at least on Fedora 28 this is handled in a backward compatible way, i.e. if I
> > want to compile against glibc I also get libxcrypt-devel and therefore crypt.h.
> > 
> > In short: I updated 2 systems from F27 to F28 and automatically have libxcrypt
> > and libxcrypt-devel available after the update. On the remaining F27 system I
> > can see that libxcrypt isn't available at all, i.e. it is a new F28 feature.
> > 
> > Just my €0.02, Stefan
> > 
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> > 
> 
> -- 
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list