[Buildroot] [PATCH 1/2] gst1-plugins-bad: rework license type construction

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun May 13 21:22:19 UTC 2018


Hello,

On Sun,  6 May 2018 15:04:02 -0400, Danomi Manchego wrote:
> Use "GST1_PLUGINS_BAD_LICENSE := $(GST1_PLUGINS_BAD_LICENSE), xxxx" construct
> so that the list of licenses is presented as a comma-separated list.
> 
> Signed-off-by: Danomi Manchego <danomimanchego123 at gmail.com>

I've applied to master, thanks! One comment below though.

>  # Add GPL license if GPL licensed plugins enabled.
>  ifeq ($(GST1_PLUGINS_BAD_HAS_GPL_LICENSE),y)
> -GST1_PLUGINS_BAD_LICENSE += GPL
> +GST1_PLUGINS_BAD_LICENSE := $(GST1_PLUGINS_BAD_LICENSE), GPL

It would be nice to make this vague "GPL" statement a bit clearer. Are
we talking about GPL-2.0, GPL-2.0+, GPL-3.0, GPL-3.0+ ? Or a
combination of these ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list