[Buildroot] [PATCH 6/8] ti-sgx-km: rename options to have proper prefix

Arnout Vandecappelle arnout at mind.be
Wed May 16 15:16:18 UTC 2018



On 16-05-18 09:00, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 15 May 2018 23:52:33 +0200, Arnout Vandecappelle wrote:
> 
>>> What is nice with this solution, is that we have the new choice that is
>>> right near the legacy option so we can chek it, and it automatically
>>> gets the old setting.
>>>
>>> But I am not too convinced, however, because we do not usually use the
>>> name of a choice elsewhere...  
>>
>>  Legacy is pretty special anyway. I do think it's worthwhile it to do this properly.
> 
> Is this an Acked-by to the approach this patch series has taken in
> terms of handling the Config.in choice option renaming ?

 Er, no, it's a NACK. I *do* think it's worthwhile to properly select the new
option.

 Regards,
 Arnout

> 
> Thanks! :-)
> 
> Thomas
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list