[Buildroot] [PATCH v5 6/7] support/scripts/pkg-stats: add CPE reporting

Matthew Weber matthew.weber at rockwellcollins.com
Fri May 18 13:05:54 UTC 2018


Thomas,

On Fri, May 18, 2018 at 2:13 AM, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
> Hello,
>
> On Thu, 17 May 2018 22:13:19 -0500, Matt Weber wrote:
>
>>      packages = get_pkglist(args.npackages, package_list)
>> -    print "Getting package make info ..."
>> +    print("Getting package make info ...")
>>      package_init_make_info()
>> -    print "Getting package details ..."
>> +    print("Getting package details ...")
>>      for pkg in packages:
>>          pkg.set_infra()
>>          pkg.set_license()
>> @@ -517,9 +584,10 @@ def __main__():
>>          pkg.set_patch_count()
>>          pkg.set_check_package_warnings()
>>          pkg.set_current_version()
>> -    print "Calculate stats"
>> +        pkg.set_cpe_info(cpedb)
>> +    print("Calculate stats")
>>      stats = calculate_stats(packages)
>> -    print "Write HTML"
>> +    print("Write HTML")
>
> I hate silly reviews, and this is a silly review, but this change to
> use parenthesis in print calls is not related to introducing CPE
> support, so it should be a separate patch (which I could merge sooner
> and separately from the CPE discussion).

Noted, Ricardo had mentioned similar.  See below.
http://patchwork.ozlabs.org/patch/916300/

Matt



More information about the buildroot mailing list