[Buildroot] [PATCH] pkg-generic: error out with 'local' site method and no _SITE

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

 > On 19-05-18 10:38, Thomas Petazzoni wrote:
 >> Hello,
 >> 
 >> On Fri, 18 May 2018 12:45:24 +0200, Arnout Vandecappelle
 >> (Essensium/Mind) wrote:
 >> 
 >>> +ifeq ($$($(2)_OVERRIDE_SRCDIR),)
 >>> +$$(error $(1) has local site method, but `$(2)_SITE_METHOD` is not defined)
 >>> +endif
 >> 
 >> Are you sure it shouldn't be "$(2)_SITE" is not defined ?

 >  That was actually intentional. The idea is to allow 'local' packages to set
 > either _SITE or _OVERRIDE_SRCDIR. The check comes after the assignment to
 > _OVERRIDE_SRCDIR. The reason for this is: currently, 'local' packages work
 > correctly if you set _OVERRIDE_SRCDIR instead of _SITE, and I don't see a reason
 > to make them fail.

 >  I probably should have explained this in the commit log. It was a bit short :-)

Indeed! Will you send an update?

-- 
Bye, Peter Korsgaard