[Buildroot] Queries/suggestions regarding patch series "grub2: add support for arm and aarch64"

Erico Nunes nunes.erico at gmail.com
Fri Nov 2 13:10:15 UTC 2018


On Fri, Nov 2, 2018 at 12:00 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello Sumit,
>
> On Fri, 2 Nov 2018 16:23:37 +0530, Sumit Garg wrote:
>
> > Yes disk-signature is disk-wide identifier. But it could work with
> > multiple partitions in following manner:
> >
> > Like the change, I have proposed with disk-signature = 0xDEEDBEEF,
> > PARTUUID=deedbeef-02 refers to 2nd partition in disk with
> > corresponding signature.
>
> Aaah, yes, I had entirely missed the -02 part in the root=PARTUUID=
> statement. Indeed, it's a lot clearer now how this can work.
>
> > AFAIK, I don't think partitioning format changes for a particular
> > device boot sequence if underlying disk changes (usb, sata, mmc etc.).
> > So "-02" string should remain a constant.
>
> Yes, absolutely! Thanks for the additional explanation!

That looks nice indeed.

So I propose that if I need to respin the grub2 arm series, I will
incorporate the PARTUUID change. Otherwise, I can later send a
separate patchset changing it for aarch64_efi and the pc_* defconfigs.

Erico



More information about the buildroot mailing list