[Buildroot] [PATCH/next 1/1] sdl2: fix build with --disable-threads

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Nov 23 21:02:04 UTC 2018


Hello,

On Wed, 21 Nov 2018 23:09:23 +0100, Fabrice Fontaine wrote:
> SDL_LinuxSetThreadPriority() has been added since version 2.0.9 and
> https://github.com/SDL-mirror/SDL/commit/f25a7fa870bdceb339e5105973f689606bcb9086
> 
> However, this function is used in src/dynapi/SDL_dynapi_procs.h even
> when SDL_THREADS_DISABLED
> 
> However, when SDL_THREADS_DISABLED is set, SDL_LinuxSetThreadPriority is
> not defined because thread/pthread/SDL_systhread.c is not built
> 
> So check SDL_THREADS_DISABLED in addition to __LINUX__
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/539cb9ab6c605dc6be73ebe90debab1a998f2451
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  .../0001-fix-build-with-disable-threads.patch | 63 +++++++++++++++++++
>  1 file changed, 63 insertions(+)
>  create mode 100644 package/sdl2/0001-fix-build-with-disable-threads.patch

I like how the inverted SDL_THREADS_DISABLED macro makes the code
readable. !SDL_THREADS_DISABLED means thread support is enabled...

But anyway, that's not your fault, that's how the existing SDL2 code
is. So applied to next, thanks! Please make sure you submit this
upstream.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list