[Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Wed Oct 10 13:29:09 UTC 2018
Jörg, Bernd,
On Tue, 21 Aug 2018 20:52:45 +0200, Jörg Krause wrote:
> > -LUVI_VERSION = v2.7.6
> > -LUVI_SOURCE = luvi-src-$(LUVI_VERSION).tar.gz
> > -LUVI_SITE = https://github.com/luvit/luvi/releases/download/$(LUVI_VERSION)
> > +LUVI_VERSION = v2.8.0
> > +LUVI_SITE = https://github.com/luvit/luvi.git
> > +LUVI_SITE_METHOD = git
> > +LUVI_GIT_SUBMODULES = YES
> > LUVI_LICENSE = Apache-2.0
> > LUVI_LICENSE_FILES = LICENSE.txt
> > LUVI_DEPENDENCIES = libuv luajit luv host-luajit
>
> I am not so happy about the version bump as version 2.8.0 does only
> updates the projects submodules, which we are not using at all.
> Instead, we always build luvi with dependencies provided as packages in
> Buildroot.
>
> Bumping to version 2.8.0 has the drawback that fetching the package
> needs much longer now due to the git submodules than fetching the
> tarball and building against the packages provided by Buildroot.
Should we revert this 2.8.0 bump then ? If you want to do that, could
you send a patch, and made add a comment in luvi.mk that explains why
bumping to 2.8.0 is useless ?
Also, luvi 2.8.0 has been causing a number of build failures:
http://autobuild.buildroot.net/?reason=luvi-v2.8.0. They need to be
fixed, or indeed reverting will be the only solution.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list