[Buildroot] [PATCH v2] poco: disable fpenvironment for MIPS without FPU

Yegor Yefremov yegorslists at googlemail.com
Wed Oct 10 08:23:57 UTC 2018


On Wed, Oct 10, 2018 at 9:45 AM Arnout Vandecappelle <arnout at mind.be> wrote:
>
>
>
> On 10/10/18 09:14, Yegor Yefremov wrote:
> > On Wed, Oct 10, 2018 at 9:12 AM Thomas Petazzoni
> > <thomas.petazzoni at bootlin.com> wrote:
> >>
> >> Hello,
> >>
> >> On Wed, 10 Oct 2018 09:02:02 +0200, Yegor Yefremov wrote:
> >>
> >>>> Isn't the glibc bug that it allowed to use fpenv in situations where it
> >>>> shouldn't have allowed it ? If that's the case, perhaps the other
> >>>> libcs didn't had this bug, and fpenv really shouldn't be used with MIPS
> >>>> soft-float, regardless of the C library in use ?
> >>>
> >>> I've made a compile test with musl and it fails too. So I'll just
> >>> disable fpenv if BR2_MIPS_SOFT_FLOAT is selected. So ne need to
> >>> mention glibc.
> >>>
> >>> Strange, that it didn't show up in the build tests ...
> >>
> >> We don't test mips/musl in the autobuilders. However, we do test
> >> mips/uclibc, but maybe not in soft-float mode.
> >
> > uclibc has special handling: both fpenv and wstring will be disabled.
>
>  So, to be fully correct, poco should be build-tested and preferably
> runtime-tested on all these softfloat architectures.
>
>  Wouldn't it be a lot simpler to just disable the whole fpenv stuff on soft
> float unconditionally? Yes, this is not perfect, because there are a few cases
> where it actually *does* work. But if someone needs those cases, let them please
> write a proper configure script that detects them. Until then, disable the
> entire feature on soft float.

Patch already sent. I've tried ARM with soft floating point and it
also fails with enabled fpenvironment.

Yegor



More information about the buildroot mailing list