[Buildroot] [PATCH 4/4] webkitgtk: explicitly set USE_GSTREAMER_GL build option
Yann E. MORIN
yann.morin.1998 at free.fr
Thu Oct 11 19:23:43 UTC 2018
Peter, Arnout, All,
On 2018-10-11 20:16 +0200, Peter Korsgaard spake thusly:
> >>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
> > 'imply' is syntactic sugar for 'default y if ...'. The *only* thing it changes
> > is the place where you put the imply. (To be exact, it is the same as 'default
> > ...' because it propagates the m/y/n state to the default, not just y/n. But
> > since we don't use m, it doesn't matter.)
>
> > For this specific case, it is pretty obvious that putting a 'default y if
> > BR2_PACKAGE_WEBKITGTK_MULTIMEDIA' on BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
As the submitter said "in general it is preferred due to better
performance", why don't we just have, in webkitgtk:
select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL if BR2_PACKAGE_GST1_PLUGINS_BAD
Or even further:
select BR2_PACKAGE_GST1_PLUGINS_BAD
select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
Of course, that requires propagating the required dependencies...
But since webkitgtk already depends on libgtk3, which itself depends on
LIBEGL_WAYLAND or LIBGL, we're not too far off...
> > would be crazy. On the other hand, adding the imply in webkitgtk looks nice,
> > concise and clear.
Sorry, I am still not convinced that using 'imply' in Buildroot is a
good idea overall... :-(
> Exactly, which is why I suggested it to Adrian.
On the other hand, this is webkitgtk we're speaking here. It's already
huge, really huge. What would be the problem with 'select'ing
GST1_PLUGINS_BAD_PLUGIN_GL if it is known to be the 'best' solution
(even if not strictly required) ?
But I'm done speaking about it now.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list