[Buildroot] [PATCH 1/1] cc-tool: use the same C++ standard as boost

Matthew Weber matthew.weber at rockwellcollins.com
Tue Oct 23 13:12:32 UTC 2018


Ferdinand,

On Tue, Oct 23, 2018 at 8:05 AM Ferdinand van Aartsen
<ferdinand at ombud.nl> wrote:
>
> Matthew Weber schreef op 2018-10-23 13:18:
> > Ferdinand,
> >
> > On Mon, Oct 22, 2018 at 9:18 AM Ferdinand van Aartsen
> > <ferdinand at ombud.nl> wrote:
> >>
> >> When boost context is enabled, we build boost with -std=c++11.
> >> That causes cc-tool to fail, which was using the gcc default c++14.
> >>
> >> Signed-off-by: Ferdinand van Aartsen <ferdinand at ombud.nl>
> >> ---
> >>  package/cc-tool/cc-tool.mk | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >> diff --git a/package/cc-tool/cc-tool.mk b/package/cc-tool/cc-tool.mk
> >> index e170e06a21..d5de920f6a 100644
> >> --- a/package/cc-tool/cc-tool.mk
> >> +++ b/package/cc-tool/cc-tool.mk
> >> @@ -18,6 +18,11 @@ CC_TOOL_AUTORECONF = YES
> >>  CC_TOOL_CONF_OPTS = --with-boost=$(STAGING_DIR)/usr
> >>  CC_TOOL_CONF_ENV = LIBS="$(CC_TOOL_LIBS)"
> >>
> >> +# With boost context selected, boost gets built with c++11
> >> +ifeq
> >> ($(BR2_PACKAGE_BOOST_CONTEXT)$(BR2_TOOLCHAIN_GCC_AT_LEAST_4_7),yy)
> >> +CC_TOOL_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
> >> +endif
> >> +
> >>  # Help boost.m4 find the Boost Regex library, which needs the pthread
> >>  # library, but isn't detected using a modern (pkg-config) mechanism.
> >>  ifeq ($(BR2_STATIC_LIBS),y)
> >> --
> >
> > I believe this one is related to this patch, any impacts?
> > http://patchwork.ozlabs.org/patch/983327/
> >
>
> You're right, hadn't spotted that one, then that seems to be the correct
> solution.

Would you mind providing your review/tested by on that series?

Thanks!
Matt



More information about the buildroot mailing list