[Buildroot] [PATCH v1 1/4] qt5virtualkeyboard: fix example build issue with 5.6

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Sep 5 20:47:15 UTC 2018


Hello Gaël,

On Mon,  3 Sep 2018 08:37:44 -0400, Gaël PORTAY wrote:
> The patch does not apply properly and needs to be fixed.
> 
> The patch was backported from 5.7 [1] with path adaptation in commit
> (cb97d9473b qt5virtualkeyboard: allow to build with qt5.6), but the
> submitted patch did not reflect that said adaptation.
> 
> Apply the said patch adaptation (i.e. add missing basic subdirectory) to
> apply properly the patch.
> 
> Fixes:
> 
> 	>>> qt5virtualkeyboard 2.0 Patching  
> 
> 	Applying 0001-remove-weird-install-path-for-example.patch using patch:
> 	patching file examples/virtualkeyboard/basic/basic.pro
> 	Hunk #1 FAILED at 7.
> 	1 out of 1 hunk FAILED -- saving rejects to file examples/virtualkeyboard/basic/basic.pro.rej
> 	make: ***[/home/test/autobuild/run/instance-2/output/build/qt5virtualkeyboard-2.0/.stamp_patched] Error 1
> 
> [1]: https://github.com/qt/qtvirtualkeyboard/commit/aef55eb7b3470ba6dee4abc67acda1d308c90e97
> 
> Signed-off-by: Gaël PORTAY <gael.portay at savoirfairelinux.com>

The title is wrong: it does not fix the "example build", it fixes
applying the patches. Even if you don't build the examples, the patch
doesn't apply and prevents building the package entirely.

I fixed up the title and did some minor tweaks in the commit log, and
applied to master. Thanks!

We really need something that tests the build of this Qt stack in 5.6
version, because we have found many legal-info issues and build issues
recently.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list