[Buildroot] [PATCH v2 12/14] gst1-plugins-base: add missing license file hash

Peter Seiderer ps.report at gmx.net
Thu Sep 27 20:18:33 UTC 2018


Hello Thomas,

On Tue, 25 Sep 2018 23:14:34 +0200, Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:

> Hello,
> 
> On Tue, 25 Sep 2018 22:36:16 +0200, Peter Seiderer wrote:
> > Signed-off-by: Peter Seiderer <ps.report at gmx.net>
> > ---
> > Changes v1 -> v2:
> >   - no changes
> > ---
> >  package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash
> > index a98abdf38b..6ef34594a0 100644
> > --- a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash
> > +++ b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash
> > @@ -1,3 +1,3 @@
> >  # From https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-1.14.3.tar.xz.sha256sum
> >  sha256 f0b319c36be0ffc2a00380c77ba269cdf04e2b39bbc49d30b641fc35aa0b7952 gst-plugins-base-1.14.3.tar.xz
> > -sha256 78fb5977f177ab71cba77a4a127d29b93cb1ca5c25962204b31f183a20cf5c7a COPYING  
> 
> I'm not sure why you're dropping this hash. The COPYING file still
> exists, it still has the same hash, and you didn't mention it in your
> commit log. So I've reverted this part of the change when applying.

Sorry for not mentioning in the commit log, the reasoning was that COPYING is
never reverenced in the gst1-plugins-base.mk file...

Regards,
Peter

> 
> > +sha256 f445dc78b88496f7e20c7a2a461b95baba5865c8919b8289ac24ac0a80c6ce7a COPYING.LIB  
> 
> Thanks,
> 
> Thomas




More information about the buildroot mailing list