[Buildroot] [PATCH v2 2/6] package/linux-headers: add support for custom headers

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Sep 12 15:23:00 UTC 2018


Hello,

On Wed, 12 Sep 2018 11:22:52 +0100, Mark Corbin wrote:

>  define LINUX_HEADERS_APPLY_LOCAL_PATCHES
> -	for p in $(filter-out ftp://% http://% https://%,$(LINUX_HEADERS_PATCHES)) ; do \
> -		if test -d $$p ; then \
> -			$(APPLY_PATCHES) $(@D) $$p \*.patch || exit 1 ; \
> -		else \
> -			$(APPLY_PATCHES) $(@D) `dirname $$p` `basename $$p` || exit 1; \
> -		fi \
> -	done
> +        for p in $(filter-out ftp://% http://% https://%,$(LINUX_HEADERS_PATCHES)) ; do \
> +                if test -d $$p ; then \
> +                        $(APPLY_PATCHES) $(@D) $$p \*.patch || exit 1 ; \
> +                else \
> +                        $(APPLY_PATCHES) $(@D) `dirname $$p` `basename $$p` || exit 1; \
> +                fi \
> +        done

This change is spurious: you just replaced the tab-based indentation by
space-based indentation, which is not good.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list